Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: independent language server for SCSS, Sass indented and CSS #237

Merged
merged 23 commits into from
Sep 28, 2024
Merged

feat: independent language server for SCSS, Sass indented and CSS #237

merged 23 commits into from
Sep 28, 2024

Conversation

wkillerud
Copy link
Owner

@wkillerud wkillerud commented Sep 22, 2024 •
edited
Loading

Fixes #236

TODO

  • Use enabled-settings in the server to turn on/off calls to language-services (there are internal dependencies between methods there, for instance links, so it needs to be handled close to the edge).
  • Regression test with out-of-the-box experience in VS Code.
  • Test the recommended all in approach in VS Code.
  • Smoketest in Helix.
  • Smoketest in Sublime.
  • Release notes, migration instructions for settings.
  • Squash, mark as breaking change, :shipit:

@wkillerud
feat: handle all features for css and scss by default
1139488 
BREAKING CHANGE: See (issue number)
@wkillerud
feat: add a more customisable logger
0d1d3aa
@wkillerud
feat: adopt all non-formating settings from Code
d4082cb
@wkillerud
refactor: to use new settings
8a4a021
@wkillerud
chore: drop development build
ff427fe
@wkillerud
chore: lodash bundled, not a dep
3b0ca4c
@wkillerud
chore: config, build
627765e
@wkillerud
feat: cli
c0b663a
@wkillerud
docs: new settings
42d8306
@wkillerud
refactor: fix loglevel type
3da7b02
@wkillerud
feat: turn off features with settings
f572214
@wkillerud
test: assertion
32c2a5a
@wkillerud
refactor: tweak settings UI
37c71fa
@wkillerud
fix: don't lose default settings from Code if v1 exists
c12b8ee
@wkillerud
fix: look for name equality
c1a02dd 
Had an odd findDefinition where a Go to defintion for $_var
found $_var and $_varsling. I don't recall why this was includes
in the first place.
@wkillerud
fix: loglevel
6466f97
@wkillerud
fix: log migration help for old settings
9ca727a
@wkillerud
fix: await things so we can log
6c24f34
@wkillerud
fix: setting for css completions in Sass, SCSS
35da87b
@wkillerud wkillerud marked this pull request as ready for review September 26, 2024 17:36
wkillerud
wkillerud commented Sep 26, 2024
View reviewed changes
docs/src/language-server/configure-a-client.md Outdated Show resolved Hide resolved
docs/src/user-guide/settings.md Outdated Show resolved Hide resolved
packages/language-server/src/server.ts Outdated Show resolved Hide resolved
packages/language-server/src/server.ts Outdated Show resolved Hide resolved
packages/language-server/src/server.ts Outdated Show resolved Hide resolved
packages/language-services/src/features/do-complete.ts Outdated Show resolved Hide resolved
packages/language-services/src/features/find-symbols.ts Outdated Show resolved Hide resolved
packages/language-services/src/language-services.ts Outdated Show resolved Hide resolved
vscode-extension/package.json Outdated Show resolved Hide resolved
vscode-extension/src/client.ts Outdated Show resolved Hide resolved
@wkillerud wkillerud merged commit f696981 into main Sep 28, 2024
2 checks passed
@wkillerud wkillerud deleted the standalone branch September 28, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let some-sass-language-server handle all features for CSS and SCSS
1 participant
@wkillerud